net: add setTypeOfService and getTypeOfService to Socket #61503

amyssnippet · 2026-01-24T11:11:33Z

this PR implements socket.setTOS(tos) and socket.getTOS() in net.Socket. it needed this to support DSCP tagging (QoS) for traffic prioritization, which wasn't previously exposed in the JS API. for the implementation:

I added the logic in tcp_wrap.cc to attempt IP_TOS first, and fallback to IPV6_TCLASS if that fails. This handles both IPv4 and IPv6 sockets automatically without needing a separate flag.
Windows returns UV_ENOSYS for now since the headers/implementation differ there.
Added a new test file (test-net-socket-tos.js) to verify input validation and ensure the values are actually set on supported platforms.

Fixes: #61489

nodejs-github-bot · 2026-01-24T11:11:39Z

Review requested:

@nodejs/net

mcollina

Good work. Can you add the documentation?

test/parallel/test-net-socket-tos.js

doc/api/net.md

src/tcp_wrap.cc

test/parallel/test-net-socket-tos.js

amyssnippet · 2026-01-24T16:03:04Z

Thanks @mcollina , is this ready to be merged? Please let me know if there is anything else you need me to adjust.

src/tcp_wrap.cc

nodejs-github-bot · 2026-01-25T07:11:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71012/

ronag · 2026-01-25T10:53:10Z

@mcollina I'm confused by the CI failures. Any ideas? Or just flaky?

amyssnippet · 2026-01-29T16:29:39Z

i checked the failing console logs of the ci failures, and thats totally flaky, kindly consider running the ci tests of github actions, and lets moove forward merging. Thank You!

juanarbol · 2026-01-29T16:39:04Z

i checked the failing console logs of the ci failures, and thats totally flaky, kindly consider running the ci tests of github actions, and lets moove forward merging. Thank You!

We can't, let me re-trigger the CI

nodejs-github-bot · 2026-01-29T16:40:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71122/

amyssnippet · 2026-01-29T16:40:23Z

We can't, let me re-trigger the CI

but its all flaky, totally unrelated to my changes

juanarbol · 2026-01-29T16:46:06Z

totally unrelated to my changes

I know, but we can't land when CI is not happy. No worries, your changes will land soon-ish :)

amyssnippet · 2026-01-29T17:40:40Z

@juanarbol i guess its due to overhead use of the jenkins ci system. you can check each and every logs i have cited them here. its not my code fault its systems fault.

Failures:

[Finished Build : #21908 of Job : node-test-commit-arm-debug with status : FAILURE at 11:44:37](https://ci.nodejs.org/job/node-test-commit-arm-debug/21908/nodes=ubuntu2404_debug-arm64/console) - reason No space left on device

[Finished Build : #61939 of Job : node-test-commit-arm with status : FAILURE at 12:01:39](https://ci.nodejs.org/job/node-test-commit-arm/61939/nodes=ubuntu2404-arm64/console) - same reason no space left on device

even unstable build failures are due to the system cant run programs like git

nodejs-github-bot · 2026-01-29T18:17:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71124/

amyssnippet · 2026-01-30T02:51:09Z

Warning

one ci is freezed, not even initiating. https://ci.nodejs.org/job/node-test-commit-arm-debug/21909/console

@ronag @mcollina @juanarbol @anonrig kindly check on this

nodejs-github-bot · 2026-01-30T06:34:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71128/

amyssnippet · 2026-01-30T14:35:28Z

Now @juanarbol ??

mcollina

lgtm

nodejs-github-bot · 2026-01-30T23:57:17Z

Commit Queue failed

- Loading data for nodejs/node/pull/61503
✔  Done loading data for nodejs/node/pull/61503
----------------------------------- PR info ------------------------------------
Title      net: add setTypeOfService and getTypeOfService to Socket (#61503)
Author     Amol Yadav  <amyssnipet@yahoo.com> (@amyssnippet, first-time contributor)
Branch     amyssnippet:fix/61489 -> nodejs:main
Labels     c++, semver-minor, lib / src, author ready
Commits    34
 - net: add setTOS and getTOS to Socket
 - added doc
 - fixed some lint issues
 - already complete with validation and platform specific tests
 - added: REPLACEME
 - common.mustCall used
 - undo: unrelated header was removed irrelevantly
 - fix: resolve windows compilation and linter issues
 - rollback to tcp only
 - fix: ensure getTOS returns numeric default when handle lacks getTOS
 - fix: handle setTOS errors in afterConnect and use options.tos
 - fix: capture errno immediately after getsockopt failures
 - fix: use correct length type for Windows getsockopt and fix DSCP mask…
 - fix: validate options.tos in constructor
 - fix: use validateInt32 for options.tos and standardize GetTOS error
 - fix: remove unused errno_val in TCPWrap::GetTOS POSIX path
 - test: add boundary value assertions for TOS
 - test: add pre-connect TOS caching test
 - doc: add notes for setTOS and getTOS about pre-connect caching and OS…
 - fix: import UV_EBADF and remove duplicate mask declaration
 - fix: update TOS cache when handle lacks setTOS
 - doc: clarify pre-connect TOS test comment
 - refined: comments
 - doc: remove prohibited 'Note that' phrases
 - fix: reorder includes for Windows compatibility and add missing POSIX…
 - fix: resolve windows header order and doc lint errors
 - feat: rename setTOS/getTOS to setTypeOfService/getTypeOfService for A…
 - fix: update internal handle calls to use new TypeOfService method names
 - win vs2022 ci fix
 - added: todo for libuv api
 - fixed:win vs2022 lint ci
 - feat: rename C++ methods from SetTOS/GetTOS to SetTypeOfService/GetTy…
 - docs: update net.md for typeOfService option and fix lib/net.js const…
 - Apply suggestions from code review
Committers 2
 - Amol Yadav <amyssnipet@yahoo.com>
 - GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/61503
Fixes: https://github.com/nodejs/node/issues/61489
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61503
Fixes: https://github.com/nodejs/node/issues/61489
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 24 Jan 2026 11:11:33 GMT
   ✔  Approvals: 3
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/61503#pullrequestreview-3731022920
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/61503#pullrequestreview-3730004460
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/61503#pullrequestreview-3711651185
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-01-30T06:34:48Z: https://ci.nodejs.org/job/node-test-pull-request/71128/
- Querying data for job/node-test-pull-request/71128/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ⚠  PR author is a new contributor: @amyssnippet(amyssnipet@yahoo.com)
   ⚠  - commit d53c0157fc93 is authored by ronagy@icloud.com
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/21534816018

nodejs-github-bot · 2026-01-31T02:05:35Z

Commit Queue failed

- Loading data for nodejs/node/pull/61503
✔  Done loading data for nodejs/node/pull/61503
----------------------------------- PR info ------------------------------------
Title      net: add setTypeOfService and getTypeOfService to Socket (#61503)
Author     Amol Yadav  <amyssnipet@yahoo.com> (@amyssnippet, first-time contributor)
Branch     amyssnippet:fix/61489 -> nodejs:main
Labels     c++, semver-minor, lib / src, author ready, commit-queue-squash
Commits    34
 - net: add setTOS and getTOS to Socket
 - added doc
 - fixed some lint issues
 - already complete with validation and platform specific tests
 - added: REPLACEME
 - common.mustCall used
 - undo: unrelated header was removed irrelevantly
 - fix: resolve windows compilation and linter issues
 - rollback to tcp only
 - fix: ensure getTOS returns numeric default when handle lacks getTOS
 - fix: handle setTOS errors in afterConnect and use options.tos
 - fix: capture errno immediately after getsockopt failures
 - fix: use correct length type for Windows getsockopt and fix DSCP mask…
 - fix: validate options.tos in constructor
 - fix: use validateInt32 for options.tos and standardize GetTOS error
 - fix: remove unused errno_val in TCPWrap::GetTOS POSIX path
 - test: add boundary value assertions for TOS
 - test: add pre-connect TOS caching test
 - doc: add notes for setTOS and getTOS about pre-connect caching and OS…
 - fix: import UV_EBADF and remove duplicate mask declaration
 - fix: update TOS cache when handle lacks setTOS
 - doc: clarify pre-connect TOS test comment
 - refined: comments
 - doc: remove prohibited 'Note that' phrases
 - fix: reorder includes for Windows compatibility and add missing POSIX…
 - fix: resolve windows header order and doc lint errors
 - feat: rename setTOS/getTOS to setTypeOfService/getTypeOfService for A…
 - fix: update internal handle calls to use new TypeOfService method names
 - win vs2022 ci fix
 - added: todo for libuv api
 - fixed:win vs2022 lint ci
 - feat: rename C++ methods from SetTOS/GetTOS to SetTypeOfService/GetTy…
 - docs: update net.md for typeOfService option and fix lib/net.js const…
 - Apply suggestions from code review
Committers 2
 - Amol Yadav <amyssnipet@yahoo.com>
 - GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/61503
Fixes: https://github.com/nodejs/node/issues/61489
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61503
Fixes: https://github.com/nodejs/node/issues/61489
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 24 Jan 2026 11:11:33 GMT
   ✔  Approvals: 3
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/61503#pullrequestreview-3731022920
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/61503#pullrequestreview-3730004460
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/61503#pullrequestreview-3711651185
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-01-30T23:57:17Z: https://ci.nodejs.org/job/node-test-pull-request/71128/
- Querying data for job/node-test-pull-request/71128/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ⚠  PR author is a new contributor: @amyssnippet(amyssnipet@yahoo.com)
   ⚠  - commit d53c0157fc93 is authored by ronagy@icloud.com
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/21536896438

juanarbol · 2026-01-31T03:30:26Z

Apparently commit-queue job is failing because of d53c015, which was committed by somebody else. And triggered because a new contributor.

Refs: https://github.com/nodejs/node-core-utils/blob/19b468ad088a8200eabdc94a96f58a6027e2fc11/lib/pr_checker.js#L84

amyssnippet · 2026-01-31T03:39:21Z

Apparently commit-queue job is failing because of d53c015, which was committed by somebody else. And triggered because a new contributor.

Refs: https://github.com/nodejs/node-core-utils/blob/19b468ad088a8200eabdc94a96f58a6027e2fc11/lib/pr_checker.js#L84

so what should i do?? @ronag commited and he is member too

net: add setTOS and getTOS to Socket

eb53d09

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 24, 2026

mcollina requested changes Jan 24, 2026

View reviewed changes

test/parallel/test-net-socket-tos.js Outdated Show resolved Hide resolved

mcollina requested a review from ronag January 24, 2026 13:16

mcollina added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 24, 2026

amyssnippet added 3 commits January 24, 2026 19:08

added doc

9e7a183

fixed some lint issues

14b3fb0

already complete with validation and platform specific tests

f339cd0

amyssnippet requested a review from mcollina January 24, 2026 13:41

amyssnippet mentioned this pull request Jan 24, 2026

socket.setTOS #61489

Open

mcollina requested changes Jan 24, 2026

View reviewed changes

doc/api/net.md Outdated Show resolved Hide resolved

doc/api/net.md Outdated Show resolved Hide resolved

src/tcp_wrap.cc Show resolved Hide resolved

test/parallel/test-net-socket-tos.js Outdated Show resolved Hide resolved

amyssnippet added 2 commits January 24, 2026 19:52

added: REPLACEME

d32f212

common.mustCall used

71ecbd7

amyssnippet requested a review from mcollina January 24, 2026 14:34

ronag approved these changes Jan 24, 2026

View reviewed changes

ronag reviewed Jan 24, 2026

View reviewed changes

src/tcp_wrap.cc Outdated Show resolved Hide resolved

ronag mentioned this pull request Jan 24, 2026

Type of Service (IP prioritization) nodejs/undici#4765

Open

undo: unrelated header was removed irrelevantly

c0407b2

amyssnippet force-pushed the fix/61489 branch from 42d5142 to c0407b2 Compare January 25, 2026 05:03

amyssnippet requested a review from ronag January 25, 2026 05:05

ronag approved these changes Jan 25, 2026

View reviewed changes

ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2026

ronag mentioned this pull request Jan 25, 2026

Feature Request - Allow setting ToS on socket (rather; wrap getNativeHandle() and let you apply whatever options you wish) uNetworking/uWebSockets.js#1205

Open

amyssnippet requested a review from ronag January 29, 2026 17:47

ronag approved these changes Jan 30, 2026

View reviewed changes

mcollina approved these changes Jan 30, 2026

View reviewed changes

mcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Jan 30, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 30, 2026

juanarbol mentioned this pull request Jan 31, 2026

unix: introduce uv_socket_get_tos and uv_socket_set_tos libuv/libuv#5015

Open

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 31, 2026

amyssnippet requested review from mcollina and ronag January 31, 2026 09:46

amyssnippet mentioned this pull request Jan 31, 2026

test-repl-programmatic-history is flaky #61578

Open

Uh oh!

net: add setTypeOfService and getTypeOfService to Socket #61503

Are you sure you want to change the base?

net: add setTypeOfService and getTypeOfService to Socket #61503

Conversation

amyssnippet commented Jan 24, 2026 • edited by mcollina Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 24, 2026

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amyssnippet commented Jan 24, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 25, 2026

Uh oh!

ronag commented Jan 25, 2026

Uh oh!

amyssnippet commented Jan 29, 2026

Uh oh!

juanarbol commented Jan 29, 2026

Uh oh!

nodejs-github-bot commented Jan 29, 2026

Uh oh!

amyssnippet commented Jan 29, 2026

Uh oh!

juanarbol commented Jan 29, 2026

Uh oh!

amyssnippet commented Jan 29, 2026

Uh oh!

nodejs-github-bot commented Jan 29, 2026

Uh oh!

amyssnippet commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 30, 2026

Uh oh!

amyssnippet commented Jan 30, 2026

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jan 30, 2026

Uh oh!

nodejs-github-bot commented Jan 31, 2026

Uh oh!

juanarbol commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amyssnippet commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

amyssnippet commented Jan 24, 2026 •

edited by mcollina

Loading

amyssnippet commented Jan 30, 2026 •

edited

Loading

juanarbol commented Jan 31, 2026 •

edited

Loading

amyssnippet commented Jan 31, 2026 •

edited

Loading